Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [Actions] Improve MSYS2 setup time #9360

Merged
merged 1 commit into from Jun 13, 2021
Merged

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Jun 12, 2021

Motivation / Problem

Setup time for MSYS2 is quite slow (~90s) because we don't use the default installation, meaning MSYS2 is downloaded and installed every time.
And we also set the action to update the installation, using more time.
Then our packages are installed.

Description

With this change, it's more like for vcpkg, we just use the installation available in the virtual environment without updating it, and install our packages.
Setup time is reduced by ~60s.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@glx22 glx22 merged commit f86c66c into OpenTTD:master Jun 13, 2021
14 checks passed
Loading
@glx22 glx22 deleted the mingw-ci branch Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants