Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9358: TarScanner no longer ignores empty files #9367

Merged

Conversation

@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Jun 13, 2021

Motivation / Problem

An AI requires a file with 0 bytes to be able to start, but the tar scanner skips empty files, causing the AI to fail with a "file not found" error.
See #9358

Description

The problem is solved by allowing tar scanner to add empty files.

Limitations

It was suggested to fix it this way, but there's some uncertainty about it. I'm not familiar with this code.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Copy link
Member

@LordAro LordAro left a comment

Probably fine. Commit might want rewording on squash

Loading

@glx22 glx22 merged commit 1e6a216 into OpenTTD:master Jun 17, 2021
14 checks passed
Loading
@SamuXarick SamuXarick deleted the tar-scanner-don't-ignore-empty-files branch Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants