New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted C-string -> std::string conversions in network #9371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a25fb05
to
a9acc07
Compare
TrueBrain
reviewed
Jun 14, 2021
…of the file that is downloading
cd86685
to
4be0d8a
Compare
4be0d8a
to
db41132
Compare
rubidium42
reviewed
Jun 14, 2021
@@ -1272,7 +1272,7 @@ static void AILoadConfig(IniFile *ini, const char *grpname) | |||
continue; | |||
} | |||
} | |||
if (item->value.has_value()) config->StringToSettings(item->value->c_str()); | |||
if (item->value.has_value()) config->StringToSettings(*item->value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather use item->value.value()
but... https://twitter.com/timur_audio/status/1184424350105161730?lang=nl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Motivation / Problem
The ongoing conversion of C-string to std::string.
Description
All kinds of small, but scattered in networking code, changes to go from C-strings to std::string.
Limitations
Contains #9372.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.