Feature: Show the number of clients and companies in the online players window #9376
Conversation
telk5093
force-pushed
the
number_of_clients
branch
from
8803509
to
fe5b8ae
Compare
There was a problem hiding this comment.
- There is a problem with displaying number of clients/companies in RTL languages, such as Arabic.
I have no idea whether my code is wrong, or it will be fixed when Arabic and RTL language translators make a translation.
It's expected that it looks weird due to all kinds of different rules for ordering different things. There's nothing you can do about it, however the translators can inject special characters to ensure the string is shown correctly when translated.
It's a nice first attempt, though there are some things that could be improved to make it clearer and simpler overall.
src/network/network_gui.cpp
Outdated
| NWidget(NWID_VSCROLLBAR, COLOUR_GREY, WID_CL_SCROLLBAR), | ||
| EndContainer(), | ||
| NWidget(NWID_HORIZONTAL), | ||
| NWidget(WWT_TEXTBTN, COLOUR_GREY, WID_CL_CLIENT_NUMBER), SetFill(1, 0), SetMinimalTextLines(1, 0), SetResize(1, 0), SetAlignment(SA_RIGHT), |
There was a problem hiding this comment.
Shouldn't this be a WWT_LABEL or maybe WWT_TEXT? It's not a button you are supposed to click on, right?
There was a problem hiding this comment.
It was my intend to draw the container of the count of clients/companies as a box shape.
Anyway I changed WWT_TEXTBTN into WWT_TEXT now, though it looks weird for me.
Please let me know if there is a better idea.
There was a problem hiding this comment.
It definitely looks different, though I think it looking different is not a bad thing as it makes it more clear it is not one of the lines in the table, but rather a footer. With the text button it looked like it was part of the table.
Having said that, I think it looks better when the string is aligned in the center (SA_CENTER), as the right alignment looks weird to me. Though, that can also be my bad taste. Maybe some others have an opinion they want to share about the looks of the button and alignment of the text.
There was a problem hiding this comment.
I agree that right-alignment looks strange here. It should either be centered or left-aligned, IMO. Left alignment probably makes more sense, since this is not a button.
There was a problem hiding this comment.
Okay, let's do them.
Left:
Centre:
I like whatever and so I can't decide it.
There was a problem hiding this comment.
Center is not bad, left is OK too, both are better than right. If I have to decide I'd say center.
BTW it seems the matrix is longer than the scroll bar.
There was a problem hiding this comment.
Center looks really nice in my book :D
There was a problem hiding this comment.
OK, now make it centered.
This comment has been minimized.
This comment has been minimized.
Motivation / Problem
Thanks to @TrueBrain, we have a new Online players window by 5266359
It is nice, but hard to know how many clients and companies at once during playing a multiplayer game.
So I added an additional line to display the total number of clients and companies.
Description
This feature adds the number of clients and companies at the bottom of the online players window like screenshot below:
Limitations
There is a problem with displaying number of clients/companies in RTL languages, such as Arabic.
I have no idea whether my code is wrong, or it will be fixed when Arabic and RTL language translators make a translation.
I'm not good at C++ and OpenTTD's code so please let me know if any problems or suggestions. Thanks beforehand!
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.