Cleanup: nullptr and boolean literals instead of NULL, 0 or 1 #9377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Inconsistent
nullptr
usage, or lack thereof in some places where it still usedNULL
or0
.Inconsistent boolean usage, where it would use
0
or1
to denotefalse
ortrue
.Description
Mostly the result of some experimentation with clang-tidy.
Next to
nullptr
and boolean literals, also some simplifications of boolean logic, e.g.e?true:false
->e != 0
.Also a duplicate set of lines between both
base_station_base.h
andstation_base.h
was removed from the latter, as the latter already includes the former.Limitations
Have checked only code that was compiled by clang on my computer, so there might be other places.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.