Codechange: convert news C-strings to std::string #9378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
Jun 17, 2021
src/news_type.h
Outdated
| @@ -115,6 +115,10 @@ struct NewsTypeData { | |||
| NewsDisplay GetDisplay() const; | |||
| }; | |||
|
|
|||
| /** Container for any custom data that must be deleted after the news item has reached end-of-life. */ | |||
| struct NewsAllocatedData {}; | |||
There was a problem hiding this comment.
Is there a way we can force this type to never be used directly? (Which is presumably undesirable?)
There was a problem hiding this comment.
We could define all "default" constructors as protected and then you must make a sub class of it. On the other hand, why make a new instance of this when you can pass nullptr as easily?
So I'm not quite sure whether all the guarding against such a thing is worth it. I just added it for a tiny bit more type safety.
TrueBrain
reviewed
Jun 17, 2021
TrueBrain
reviewed
Jun 17, 2021
…locate it with new and delete
…instead of a separate function
And use std::unique_ptr to manage the memory of the allocated data
TrueBrain
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Continue the C-string to std::string conversion.
Description
Change
free_datafrom something that ismalloced/freed to something that is allocated withnewanddelete. Type this so it becomes easier to spot all types of information that get passed into there by finding the appropriate sub classes. In doing so replacestrduped strings with strings in an allocated sub class.Limitations
Practically all this information could be put in sub classes of NewsItem, but that is something that should be done at a later point.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.