Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Wrong cargo line position in IndustryCargo window. #9383

Merged
merged 1 commit into from Jun 17, 2021

Conversation

@PeterN
Copy link
Member

@PeterN PeterN commented Jun 17, 2021

Motivation / Problem

Cargo line position in industry cargo window was incorrect when many cargo types are present. This was noticed with the OTIS NewGRF at https://www.tt-forums.net/viewtopic.php?p=1242719#p1242719

Description

Resolved by changing calculation to determine the offset based on centring the cargo lines in the available space.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Resolved by changing calculation to determine the offset based on centring the cargo lines in the available space.
@PeterN
Copy link
Member Author

@PeterN PeterN commented Jun 17, 2021

Without this change:
without9383

With this change:
with9383

Loading

@PeterN PeterN merged commit ce7ef4d into OpenTTD:master Jun 17, 2021
14 checks passed
Loading
@PeterN PeterN deleted the fix-industry-cargo-spacing branch Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants