Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9392: Return a valid value with GetBuildWithRefitCapacity when AIs are maxed out in vehicles #9393

Merged

Conversation

@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Jun 21, 2021

Motivation / Problem

fixes #9392

Description

The problem is solved by allowing a unit number of 0 for temporary vehicles using DC_QUERY_COST flag which is passed by GetBuildWithRefitCapacity.

Limitations

I'm not really sure this will work in all cases. refitting and subflags and the temporary v that may and may not exist and then the DC_EXEC and non exec modes make it quite complex to test every scenario.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@glx22 glx22 merged commit 76b8343 into OpenTTD:master Aug 11, 2021
14 checks passed
Loading
@SamuXarick SamuXarick deleted the BuildWithRefitCapacity-max-vehicles-fix branch Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants