Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change #9188: Netsave now behaves like autosave #9395

Merged
merged 1 commit into from Jul 9, 2021
Merged

Change #9188: Netsave now behaves like autosave #9395

merged 1 commit into from Jul 9, 2021

Conversation

@Taschi120
Copy link
Contributor

@Taschi120 Taschi120 commented Jun 23, 2021

No description provided.

glx22
glx22 reviewed Jun 25, 2021
View changes
src/saveload/saveload.cpp Outdated Show resolved Hide resolved
Loading
src/saveload/saveload.cpp Outdated Show resolved Hide resolved
Loading
src/saveload/saveload.cpp Outdated Show resolved Hide resolved
Loading
src/saveload/saveload.cpp Outdated Show resolved Hide resolved
Loading
@Taschi120 Taschi120 mentioned this pull request Jun 25, 2021
Merged
@Taschi120
Copy link
Contributor Author

@Taschi120 Taschi120 commented Jun 25, 2021

Note that this PR and PR #9397 have conflicts.

I'll fix the review comments during the weekend. Thanks for the feedback.

Loading

Taschi120 added a commit to Taschi120/OpenTTD that referenced this issue Jun 26, 2021
@Taschi120
Cleanup: Implemented suggestions from code review on PR OpenTTD#9395
33e1b7e
glx22
glx22 reviewed Jun 26, 2021
View changes
src/saveload/saveload.cpp Outdated Show resolved Hide resolved
Loading
src/saveload/saveload.h Outdated Show resolved Hide resolved
Loading
Taschi120 added a commit to Taschi120/OpenTTD that referenced this issue Jun 27, 2021
@Taschi120
Cleanup: Implemented suggestions from code review on PR OpenTTD#9395
e1f7b6d
@Taschi120
Copy link
Contributor Author

@Taschi120 Taschi120 commented Jun 28, 2021

I'm have no idea why the commit checker is failing, the commit message format looks fine to me?

Loading

@LordAro
Copy link
Member

@LordAro LordAro commented Jun 28, 2021

There's a space at the beginning of the line

Loading

LordAro
LordAro reviewed Jun 28, 2021
View changes
src/saveload/saveload.cpp Outdated Show resolved Hide resolved
Loading
Taschi120 added a commit to Taschi120/OpenTTD that referenced this issue Jun 28, 2021
@Taschi120
Cleanup: Implemented suggestions from code review on PR OpenTTD#9395
cafb4e6
glx22
glx22 reviewed Jul 9, 2021
View changes
Copy link
Contributor

@glx22 glx22 left a comment

I'll fix the { in #9397

Loading

TrueBrain
TrueBrain approved these changes Jul 9, 2021
View changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Sorry @glx22 ; I also fixed some dots, capitals, and more of that nitpicking stuff. Squashed the commit and altered the commit message to make changelog easier :)

Loading

@glx22 glx22 merged commit a70aa5d into OpenTTD:master Jul 9, 2021
15 checks passed
Loading
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jul 9, 2021

Tnx for this @Taschi120 , a fine contribution to OpenTTD :D

Loading

@Taschi120
Copy link
Contributor Author

@Taschi120 Taschi120 commented Jul 9, 2021

I'll pop into the chat tomorrow and would be grateful if you could let me know in detail what exactly the "nitpicky" things are so I can do better in future. :)

Loading

Taschi120 added a commit to Taschi120/OpenTTD that referenced this issue Jul 11, 2021
@Taschi120
Add OpenTTD#9188: netsave now keeps multiple version around, similar …
05e3ae5 
…to autosave (OpenTTD#9395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro

@TrueBrain TrueBrain

@glx22 glx22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Taschi120 @LordAro @TrueBrain @glx22