Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9402, 2e136285: Don't pass nullptr to fund town using default name #9403

Merged
merged 1 commit into from Jun 27, 2021

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Jun 27, 2021

Motivation / Problem

We can't pass nullptr as a std::string argument.

Description

Replace C-string with a std::string.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@glx22 glx22 changed the title Fix #9402, 2e136285: Can't convert nullptr to std::string Fix #9402, 2e136285: Don't pass nullptr to fund town using default name Jun 27, 2021
@glx22 glx22 merged commit 87eb0e4 into OpenTTD:master Jun 27, 2021
15 checks passed
Loading
@glx22 glx22 deleted the fix_9402 branch Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants