Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix f7e390bd: freeaddrinfo() is not guaranteed to handle a nullptr graceful #9404

Merged
merged 1 commit into from Jun 29, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jun 29, 2021

Motivation / Problem

Reported in a comment in #9017 . Could not confirm, as I cannot compile for Haiku.

Description

Hopefully fix a crash on Haiku. Again, no way for me to confirm this :P

(and no, I do not know why it was reported as comment in #9017, as it already didn't contain that code at that point in time :P But I am happy to fix it ofc!)

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Copy link
Member

@LordAro LordAro left a comment

Easy win is easy.

Loading

@TrueBrain TrueBrain merged commit d38079d into OpenTTD:master Jun 29, 2021
14 checks passed
Loading
@TrueBrain TrueBrain deleted the fix-freeaddrinfo branch Jun 29, 2021
Taschi120 added a commit to Taschi120/OpenTTD that referenced this issue Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants