Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 9e32c618: network revision was always empty #9419

Merged
merged 1 commit into from Jul 8, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jul 8, 2021

Motivation / Problem

I was puzzled why nothing gave a version mismatch .. till I noticed all master servers were reporting as no version :D

"Oops" :)

Description

Shadowing the variable you intend to write in tends to do that ;)

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Shadowing the variable you intend to write in tends to do that ;)
LordAro
LordAro approved these changes Jul 8, 2021
@TrueBrain TrueBrain merged commit 852e056 into OpenTTD:master Jul 8, 2021
14 checks passed
Loading
@TrueBrain TrueBrain deleted the fix-network-revision branch Jul 8, 2021
Taschi120 added a commit to Taschi120/OpenTTD that referenced this issue Jul 11, 2021
Shadowing the variable you intend to write in tends to do that ;)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants