Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: raise the maximum NewGRF limit to 255 #9428

Merged
merged 2 commits into from Jul 11, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jul 10, 2021

Motivation / Problem

Every limit is one limit too many! WE WANT MORE NEWGRFS! MOAR! MMOOAAARRRR!

Description

As the Game Info now travels via TCP, we can increase the MTU limit on both sides to allow more NewGRFs. So .. I did exactly that.

I tested it with up to 209 NewGRFs .. that was all I had on disk :P

image

Picture to proof it!

Limitations

  • 255 isn't enough. But .. a problem for another day ;)

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@TrueBrain TrueBrain force-pushed the increase-newgrf-limit branch from f1402d5 to 40cb4c9 Jul 10, 2021
@James103
Copy link
Contributor

@James103 James103 commented Jul 10, 2021

Why not just download at least 46 more NewGRFs from BaNaNaS and load them in addition to what you have already?

Loading

src/newgrf.cpp Outdated Show resolved Hide resolved
Loading
TrueBrain added 2 commits Jul 11, 2021
This statement was removed by accident, as it felt it could be removed.
But it is used to know if the NewGRF is from the baseset folder or
from the NewGRF folder.
@TrueBrain TrueBrain force-pushed the increase-newgrf-limit branch from 70fe99d to 172f0d5 Jul 11, 2021
Copy link
Contributor

@rubidium42 rubidium42 left a comment

Next rabbit hole please ;)

Loading

@TrueBrain TrueBrain merged commit f4dd2d8 into OpenTTD:master Jul 11, 2021
15 checks passed
Loading
@TrueBrain TrueBrain deleted the increase-newgrf-limit branch Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants