Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: allow setting your server visibility to "invite-only" #9434

Merged
merged 1 commit into from Jul 11, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jul 11, 2021

Motivation / Problem

As you can join based on invite codes now, it allows for servers to be registered but not public. In other words: invite-only. If you know the invite code you can join, but otherwise it won't be visible in the server-listing.

This might not seem all that useful now, as you could as well give someone your IP+port. But invite-codes are shorter, and where IPs can change, invite-codes do not.

And of course, if STUN lands, it becomes even more clear why this is useful :)

Description

In this mode you do register to the Game Coordinator, but your
server will not show up in the public server listing. You can give
your friends the invite code of the server with which they can
join.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
In this mode you do register to the Game Coordinator, but your
server will not show up in the public server listing. You can give
your friends the invite code of the server with which they can
join.
@TrueBrain TrueBrain merged commit b6a116a into OpenTTD:master Jul 11, 2021
15 checks passed
Loading
@TrueBrain TrueBrain deleted the invite-only branch Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants