Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: includes to network/core/config.h from headers when only three cpp files need it #9436

merged 1 commit into from Jul 11, 2021


Copy link

@rubidium42 rubidium42 commented Jul 11, 2021

Motivation / Problem

Changing something in network/core/config.h took ages to recompile as many .cpp files included it indirectly via settings_type.h or network_type.h even when those .h files did not need it.


Remove network/core/config.h includes from two .h files and add it two three .cpp files that actually need it.

Now changing config.h requires 50 files to be recompiled, compared to 298 before this change.



Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

TrueBrain previously approved these changes Jul 11, 2021
@rubidium42 rubidium42 merged commit 178ea31 into OpenTTD:master Jul 11, 2021
14 checks passed
@rubidium42 rubidium42 deleted the remove_includes branch Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants