Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: [Win32] Set the console codepage to UTF-8 #9444

Merged
merged 2 commits into from Jul 16, 2021

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Jul 16, 2021

Motivation / Problem

When doing tests for #9443, I noticed weird output in the console.

After some digging and testing, it appears we convert internal UTF-8 strings to UTF-16 before outputting them. And it seems the output just stops on the first "invalid" char for the console codepage (I tried many codepage and was never able to print a string from greek translation).

While testing stuff, I also notice a nice crash with -q switch.

Description

Setting the console codepage to UTF-8 allows us to directly print the string without any conversion. Even if chars are not displayable by the console font, the string itself will be fully printed.

I also fixed the -q issue.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@glx22 glx22 merged commit 16abdd5 into OpenTTD:master Jul 16, 2021
14 checks passed
Loading
@glx22 glx22 deleted the win32_console_utf8 branch Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants