Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 75b6051b: removing items from the ini could leave the group in a bad state #9445

Merged
merged 1 commit into from Jul 17, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jul 17, 2021

Motivation / Problem

@LordAro had an ini-file that crashed the game upon save. Investigation showed I fucked up IniGroup::RemoveItem ;)

Description

There are a few things going on here, but mostly last_item is a shitty name for a pointer to the ->next of the real last item. I drew some wrong conclusions because of that, resulting in a broken implementation.

Now when the last item of a group is removed, last_item points to the next of the previous value, keeping the group in a valid state.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@TrueBrain TrueBrain merged commit ab60111 into OpenTTD:master Jul 17, 2021
14 checks passed
Loading
@TrueBrain TrueBrain deleted the fix-ini-loader branch Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants