Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 75b6051b: removing items from the ini could leave the group in a bad state #9445

Merged
merged 1 commit into from Jul 17, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/ini_load.cpp
Expand Up @@ -112,8 +112,9 @@ void IniGroup::RemoveItem(const std::string &name)
if (item->name != name) continue;

*prev = item->next;
if (this->last_item == &this->item) {
this->last_item = &item->next;
/* "last_item" is a pointer to the "real-last-item"->next. */
if (this->last_item == &item->next) {
this->last_item = prev;
}

item->next = nullptr;
Expand Down