Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Crash with debug output enabled #9446

Merged
merged 1 commit into from Jul 19, 2021
Merged

Conversation

@LordAro
Copy link
Member

@LordAro LordAro commented Jul 17, 2021

Motivation / Problem

Game crashes with debug output

Description

Crash is due to fmt trying to construct a std::string out of a nullptr. Make it not do that.

Limitations

Might be others. Difficult to check for.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
src/music/fluidsynth.cpp Outdated Show resolved Hide resolved
Loading
@LordAro LordAro merged commit 1e529e1 into OpenTTD:master Jul 19, 2021
15 checks passed
Loading
@LordAro LordAro deleted the debug-crash branch Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants