Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small clean ups due to the introduction of GC #9448

Merged
merged 2 commits into from Jul 18, 2021

Conversation

@rubidium42
Copy link
Contributor

@rubidium42 rubidium42 commented Jul 18, 2021

Motivation / Problem

Effectively dead code since 8a2da49.
Out-of-date documentation since c921f6d.

Description

Remove: the concept of UnknownGRFs

These were filled with "<Unknown>" (before 8a2da49) and later their name would get filled via UDP requests to the server.
These UDP packets do not exist anymore, so they will always remain "<Unknown>".
Remove that logic and just use the generic translated error GRF UNKNOWN string instead.

And update the documentation of the GameInfo packet with the Game Script fields / for version 5.

Limitations

None. Well, the NewGRFs will now always be called "Unknown" (or whatever the translation is). Later updates to the Game Info protocol and the GC should remedy this problem in the near future (if all goes to plan).

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
rubidium42 added 2 commits Jul 18, 2021
These were filled with "<Unknown>" (before 8a2da49) and later their name would get filled via UDP requests to the server. These UDP packets do not exist anymore, so they will always remain "<Unknown>".
Remove that logic and just use the generic translated error GRF UNKNOWN string instead.
@rubidium42 rubidium42 merged commit 5dd5241 into OpenTTD:master Jul 18, 2021
13 checks passed
Loading
@rubidium42 rubidium42 deleted the gc-cleanups branch Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants