Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 57734fd: Don't enable rename button for network clients in build vehicle window #9452

merged 1 commit into from Jul 19, 2021


Copy link

@glx22 glx22 commented Jul 19, 2021

Motivation / Problem

Rename button for engines in build vehicle window must be disabled in network games if not the server.

It was done in the constructor, but 57734fd bypassed the disabling from constructor.


Restore the forced disabling.


Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

src/build_vehicle_gui.cpp Outdated Show resolved Hide resolved
@glx22 glx22 force-pushed the engine_rename_disable branch from 53d81e6 to 3e51b8d Compare Jul 19, 2021
@glx22 glx22 merged commit 9b0bb21 into OpenTTD:master Jul 19, 2021
15 checks passed
@glx22 glx22 deleted the engine_rename_disable branch Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants