Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: remove the ability to control "max spectators" #9466

Merged
merged 1 commit into from Aug 10, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Aug 10, 2021

Motivation / Problem

We want to remove the "lobby" window, as it is just an annoying window. As replacement, the "Join Game" button will join the game as spectator, from which you can move to a (new) company.

In order to get there, we need to remove "max spectators", as if you set spectators to 0, it would mean nobody can join.

Honestly, I am not sure "max spectators" has ever been useful.

Description

Removed max-spectators. For master-server info, replaced it with "max-clients" for now, as that is basically the next value .. you can never have more spectators than "max-clients" :D

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Soon we will make "join game" join the game as spectator first,
so limiting the amount of spectators makes no sense anymore in
that context. Not sure it ever did make sense.
@TrueBrain TrueBrain merged commit 4c1ea40 into OpenTTD:master Aug 10, 2021
15 checks passed
Loading
@TrueBrain TrueBrain deleted the no-more-max-spectators branch Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants