Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: report reuse of invite-code and switch to local game-type #9487

Merged
merged 1 commit into from Aug 17, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Aug 17, 2021

Motivation / Problem

Two servers can announce themselves with the same invite-code. It does mean both servers also know the secret, so it is most likely the same user starting their server on different ports.

Currently, those two will battle for who owns the invite-code, kicking the other off constantly.

Description

Instead of letting this battle go, the GC sends (since protocol version 6) an error indicating that this situation happen. To prevent the fighting going on, switch the old server to local game-type.

The server operator should be able to pick up from this, and realise he is using the same invite-code for both games.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
This prevents two servers battling for the same invite-code. Now
the last one wins.
@TrueBrain TrueBrain merged commit 6acf204 into OpenTTD:master Aug 17, 2021
14 checks passed
Loading
@TrueBrain TrueBrain deleted the fix-reuse-of-invite-code branch Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants