Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Network] crash when last-joined server that is no longer available #9503

Merged
merged 1 commit into from Aug 21, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Aug 21, 2021

Motivation / Problem

A crash that happened from time to time, but nobody could reproduce. Took me a long time staring at the traceback to figure out what causes it. But as written in the commit message:

If you update the server-list while not having last-joined selected
and it is no longer available, the game crashed.

Description

We only removed last_joined selection in the GUI if it was selected and no longer available. Also remove it if it is not selected, as drawing it will obvious fail.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
If you update the server-list while not having last-joined selected
and it is no longer available, the game crashed.
@TrueBrain TrueBrain merged commit 4066a07 into OpenTTD:master Aug 21, 2021
14 checks passed
Loading
@TrueBrain TrueBrain deleted the fix-last-joined branch Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants