Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: guidelines on english.txt or translation changes in PRs. #9505

Merged
merged 1 commit into from Aug 22, 2021

Conversation

@frosch123
Copy link
Member

@frosch123 frosch123 commented Aug 22, 2021

Motivation / Problem

Eints automates the translation commits. When people change english.txt in PRs, they keep wondering whether they will get into a fight with Eints, and win or lose.

Description

If you fight with a bot, you always lose.
Here are some guidelines how to be on the bot's side, and win with them.

Check here for easier reading: https://github.com/frosch123/OpenTTD/blob/eintsguide/docs/eints.md

Limitations

People have to read the guidelines for them to work.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Copy link
Member

@TrueBrain TrueBrain left a comment

Awesome, tnx a lot for this :D

Loading

@frosch123 frosch123 merged commit 93fd42b into OpenTTD:master Aug 22, 2021
14 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants