Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Network] show query errors in the server listing instead of error popup #9506

Merged
merged 1 commit into from Aug 23, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Aug 23, 2021

Includes #9502.

Motivation / Problem

While investigating solutions for #9490, and with the introduction of #9502, I realised how annoying the red popups are when querying servers. It makes much more sense (to me) to show the server status in the info dialog we have for it, similar to "offline".

Description

As #9502 moved all the query code to its own file, it is a lot easier to add this. Making this PR pretty straight-forward.

image
image

And similar for "Server too old".

To be clear, this is not the final solution for #9490, but at least makes it less icky.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
src/network/network_gui.cpp Outdated Show resolved Hide resolved
Loading
…or popup

When you are query several servers at once, it is rather unclear
for which server you got a popup. Instead, show any errors on the
server itself.

This is only true for the query-part. Joining a server still gives
an error popup to tell you about any issue.
@TrueBrain TrueBrain merged commit dc5b7b9 into OpenTTD:master Aug 23, 2021
15 checks passed
Loading
@TrueBrain TrueBrain deleted the server-full branch Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants