Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9241: Grove and forest tree brushes also create rainforests #9542

Merged
merged 1 commit into from Sep 12, 2021

Conversation

@vituscze
Copy link
Contributor

@vituscze vituscze commented Sep 5, 2021

Motivation / Problem

Creating rainforest in the scenario editor is exceptionally hard. The only way to make a rainforest is to plant a rainforest tree with the single-tile tree brush. See also #9241

Description

This PR allows larger tree brushes to also create rainforest tiles. The behavior of random-tree brushes remains unchanged.

Limitations

Currently, the implementation simply makes the behavior of the larger tree brushes match that of the single-tile brush. However, the zoning could be more complex (such as planting cacti also creates desert or such).

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
src/tree_gui.cpp Show resolved Hide resolved
Loading
@vituscze vituscze requested a review from TrueBrain Sep 7, 2021
@TrueBrain TrueBrain requested review from LordAro and removed request for TrueBrain Sep 9, 2021
Copy link
Member

@LordAro LordAro left a comment

If I wanted to be super pedant-y, comments on their own line should use /* */ style

Loading

@TrueBrain TrueBrain merged commit 710b758 into OpenTTD:master Sep 12, 2021
16 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants