Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't give focus to text filter when opening Object GUI #9547

Merged
merged 1 commit into from Sep 9, 2021

Conversation

@2TallTyler
Copy link
Member

@2TallTyler 2TallTyler commented Sep 9, 2021

Motivation / Problem

When opening the object window to build NewGRF objects, the text filter box is automatically given focus, so any hotkeys are typed into the textbox.

The same problem with the rail station filter in a comment on the feature PR and again in #8875, and fixed in #8885.

Text filters in other GUIs like the Town directory do not get focus upon opening the GUI, setting a further precedent to remove this auto-focus, especially now that we have a hotkey (#8908) to give focus to the textbox.

Description

The text filter does not automatically get focus upon opening the object GUI.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Copy link
Member

@TrueBrain TrueBrain left a comment

Consistencyyyyyyyy

Loading

@glx22 glx22 merged commit 66620b4 into OpenTTD:master Sep 9, 2021
15 checks passed
Loading
@2TallTyler 2TallTyler deleted the object_filter_focus branch Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants