Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: update multiplayer documentation with latest changes #9552

Merged
merged 1 commit into from Sep 12, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Sep 12, 2021

Motivation / Problem

The multiplayer documentation wrote about buttons that didn't exist, and flows that are now replaced.

Description

I went through this document to make sure it reflects reality again.

As written in the commit message:

Although several places were fixed during the PR making the change,
not all made it in this document.

While at it, removed all kinds of Markdown warnings by an excessive
usage of spacebar in this document.

Also, this includes #9539 (closes #9539). I kept the spirit of what @Berbe wrote, but made the sentences a bit shorter (his version had a lot of ,, which makes the story hard to follow). Also gave a suggestion to resolve the issue.
I hope @Berbe doesn't mind me including his PR in mine, but it is time-wise a bit more efficient to go about it this way :)

Most of the diff is whitespace, so disable viewing whitespaces if you want an easier review experience :)

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@TrueBrain TrueBrain force-pushed the docs-multiplayer branch from ee59d0b to a625df8 Sep 12, 2021
docs/multiplayer.md Outdated Show resolved Hide resolved
Loading
docs/multiplayer.md Outdated Show resolved Hide resolved
Loading
docs/multiplayer.md Outdated Show resolved Hide resolved
Loading
docs/multiplayer.md Outdated Show resolved Hide resolved
Loading
docs/multiplayer.md Outdated Show resolved Hide resolved
Loading
@TrueBrain TrueBrain force-pushed the docs-multiplayer branch 2 times, most recently from 9f8881f to 20efbf2 Sep 12, 2021
Although several places were fixed during the PR making the change,
not all made it in this document.

While at it, removed all kinds of Markdown warnings by an excessive
usage of spacebar in this document.
@TrueBrain TrueBrain force-pushed the docs-multiplayer branch from 20efbf2 to 28ed489 Sep 12, 2021
@TrueBrain TrueBrain merged commit 928e6a0 into OpenTTD:master Sep 12, 2021
16 checks passed
Loading
@TrueBrain TrueBrain deleted the docs-multiplayer branch Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants