Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add back 'Spectate' option to company toolbar menu #9556

Merged
merged 1 commit into from Sep 18, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Sep 14, 2021

Motivation / Problem

People have been using the "Spectate" in the menu as a quick way to mark themselves as "away" in multiplayer games. As we have no alternative for this flow, reinstate this button.

More details here: #9532 (comment)

Description

This is a cherry-pick of the work of JGRPP: JGRennison/OpenTTD-patches@40a6181
Which is a partial cherry-pick of #9532.
Closes #9532.

As by commit message:

This was removed in ce7406f88b, but people used this to quickly
mark themselves as away.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
This was removed in ce7406f, but people used this to quickly
mark themselves as away.
@TrueBrain TrueBrain added this to the 12.0 milestone Sep 18, 2021
Copy link
Member

@LordAro LordAro left a comment

I think this is a reasonable compromise between #9532 & current

@TrueBrain TrueBrain merged commit cd03bac into OpenTTD:master Sep 18, 2021
15 checks passed
@TrueBrain TrueBrain deleted the spectate-in-menu branch Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants