Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Allow all tiles around docks to be docking tiles #9578

Merged
merged 1 commit into from Sep 26, 2021

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Sep 26, 2021

Motivation / Problem

Sometimes a ship can't reach a dock while there is free space around it.
image
That's because only the end of dock is allowed to be a docking tile (and in this particular situation it's blocked by another dock).

Description

Allow all tiles around the dock to be docking tiles.
A savegame conversion is needed to update existing docks, and I decided to do it without a bump.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Copy link
Member

@TrueBrain TrueBrain left a comment

Guess this will alter some games, but shrug, lets go!

Loading

@TrueBrain TrueBrain dismissed their stale review Sep 26, 2021

Let's do a savegame bump, to not confuse future-us :)

src/saveload/saveload.h Outdated Show resolved Hide resolved
Loading
@glx22 glx22 merged commit 38a64eb into OpenTTD:master Sep 26, 2021
16 checks passed
Loading
@glx22 glx22 deleted the docks branch Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants