Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Console command to list search directories for various things #9583

Merged
merged 1 commit into from Sep 26, 2021

Conversation

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Sep 26, 2021

Motivation / Problem

It can be difficult to figure out exactly where to put various files for the game to find them, especially if you're running a headless (dedicated) server and need to upload files by SFTP or similar.

Description

This adds a console command that lists all the search directories for all the interesting game data files, as well as the default locations for save, autosave and screenshot files.

image

Limitations

Potentially leaks some system information when used over remote console, should this have a protection against that?

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Copy link
Member

@TrueBrain TrueBrain left a comment

Mostly nitpicks :)

Loading

src/console_cmds.cpp Outdated Show resolved Hide resolved
Loading
src/console_cmds.cpp Outdated Show resolved Hide resolved
Loading
src/console_cmds.cpp Outdated Show resolved Hide resolved
Loading
src/console_cmds.cpp Outdated Show resolved Hide resolved
Loading
@nielsmh nielsmh merged commit 5e3ed3a into OpenTTD:master Sep 26, 2021
16 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants