Fix #9591: Update station docking tiles upon placing a water object on a docking tile #9594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
reviewed
Oct 2, 2021
Seems correct, but I think a savegame bump is needed, and an update of https://github.com/OpenTTD/OpenTTD/blob/master/src/saveload/afterload.cpp#L3109 with the new version.
SamuXarick
force-pushed
the
remove-docking-tile-on-placing-object
branch
2 times, most recently
from
606eba0
to
f122756
Compare
LordAro
previously approved these changes
Oct 3, 2021
…bject on a docking tile
SamuXarick
force-pushed
the
remove-docking-tile-on-placing-object
branch
from
f122756
to
25be496
Compare
TrueBrain
reviewed
Oct 3, 2021
TrueBrain
approved these changes
Oct 3, 2021
JGRennison
added a commit
to JGRennison/OpenTTD-patches
that referenced
this issue
Oct 3, 2021
…n a docking tile (#9594) See: OpenTTD/OpenTTD#9591 See: OpenTTD/OpenTTD#9594 Non-extended savegame bump to be applied later (cherry picked from commit e404d16) # Conflicts: # src/object_cmd.cpp # src/saveload/afterload.cpp # src/saveload/saveload.h
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this issue
Oct 16, 2021
…bject on a docking tile (OpenTTD#9594)
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this issue
Oct 16, 2021
…bject on a docking tile (OpenTTD#9594)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Motivation / Problem
Placing a water object on a docking tile doesn't run
CMD_LANDSCAPE_CLEARwhich callsClearTile_Waterto do the removal of docking tiles.Description
Borrow some part of the code from
ClearTile_Waterthat deals with the removal of docking tiles and use it during object construction.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.