Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Make ships smarter #9610

Merged
merged 2 commits into from Oct 11, 2021
Merged

Change: Make ships smarter #9610

merged 2 commits into from Oct 11, 2021

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Oct 11, 2021

Fixes #9566
Closes #9567

Motivation / Problem

As reported in #9566, sometimes the only valid path to the next ship destination is behind it.
It's also possible for ships to be stuck like in image because they just go back on the same track when hitting a dead end.

Description

The first commit tests paths using forward and reverse direction when leaving a dock, and reverse the ship if it's the best solution.
The second commit tries all possible reverse directions when a dead end is hit.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@glx22 glx22 force-pushed the smarter_ships branch from aa31ac0 to 7cb82ed Oct 11, 2021
Copy link
Member

@TrueBrain TrueBrain left a comment

Sure. (I really did not understand any of it, but you are now our PF expert :P)

Loading

@glx22 glx22 merged commit cbe00ec into OpenTTD:master Oct 11, 2021
16 checks passed
Loading
@glx22 glx22 deleted the smarter_ships branch Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants