Fix #9595: Always use plural forms of cargo for subsidy strings #9619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
reviewed
Oct 17, 2021
| } else { | ||
| SetDParam(parameter_offset, cs->name_single); | ||
| } | ||
| SetDParam(parameter_offset, cs->name); |
There was a problem hiding this comment.
does this mean name_single can be removed completely?
There was a problem hiding this comment.
Probably? It's not used anywhere else. Might make reintroducing it at some point in the future difficult though
There was a problem hiding this comment.
But by the logic of this PR, it will always be a problem for translations?
There was a problem hiding this comment.
I would guess that depends on the string, but likely, yes
TrueBrain
approved these changes
Oct 17, 2021
LordAro
added
the
backport requested
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Oct 23, 2021
TrueBrain
pushed a commit
that referenced
this pull request
Oct 23, 2021
TrueBrain
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Subsidy strings use a hardcoded singular/plural form of cargo names, depending on the string. For some languages this is the wrong one and cannot be changed.
Description
Make subsidy strings always use the plural form of cargo names. Reword english strings to match (remove 'service')
Limitations
Invalidates all existing translations. Might cause the reverse problem for some languages
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.