Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Explicitly specify SHA1 for legacy code signing on Windows #9684

Merged
merged 1 commit into from Nov 10, 2021

Conversation

orudge
Copy link
Contributor

@orudge orudge commented Nov 9, 2021

Motivation / Problem

Due to an upgrade of the Windows SDK used on the GitHub Actions virtual environments, an error is printing when attempting to code sign:

SignTool Error: No file digest algorithm specified. Please specify the digest algorithm with the /fd flag. Using /fd SHA256 is recommended and more secure than SHA1. Calling signtool with /fd sha1 is equivalent to the previous behavior. In order to select the hash algorithm used in the signing certificate's signature, use the /fd certHash option.

This means the certificate is only being SHA-256 timestamped, but the SHA-1 timestamping is failing. While this doesn't really matter for modern versions of Windows, Windows Vista and possibly 7 pre-SP1 only support SHA-1.

Description

This patch updates the syntax of the SignTool call to be explicit about the digest algorithm we want to use.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro added the backport requested label Nov 9, 2021
@orudge orudge merged commit 7d40cc9 into OpenTTD:master Nov 10, 2021
16 checks passed
@TrueBrain TrueBrain added backported and removed backport requested labels Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants