Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Remove CargoSpec::multipliertowngrowth which is unused #9701

Merged

Conversation

JGRennison
Copy link
Contributor

@JGRennison JGRennison commented Nov 16, 2021

Motivation / Problem

CargoSpec::multipliertowngrowth was added in 3d581f4, but no readers have been added since then.
It seems unlikely that readers will be added in the near future.

CargoSpec::multipliertowngrowth is set by cargo property 19.
Cargo property 19 is only implemented in TTDPatch.

The name looks enticing to NewGRF authors, but they are then confused and disappointed when setting it seems to do nothing.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

This is set by cargo property 19.
This property is only implemented in TTDPatch.
@JGRennison JGRennison force-pushed the remove-cargospec-multipliertowngrowth branch from 0ad883d to a2f9419 Compare Nov 16, 2021
@LordAro LordAro merged commit fc58ed9 into OpenTTD:master Nov 16, 2021
16 checks passed
@JGRennison JGRennison deleted the remove-cargospec-multipliertowngrowth branch Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants