Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #9725: Replace cmd_helper related functions and remove cmd_helper.h #9783

Merged
merged 1 commit into from Feb 2, 2022

Conversation

J0anJosep
Copy link
Contributor

@J0anJosep J0anJosep commented Jan 8, 2022

Description

After #9725, cmd_helper is almost useless.

The few remaining IsEnumValid() can be replaced with IsValidDirection(), IsValidAxis...
The few remaining Extract<>() in story.cpp can also be replaced.

Limitations

I don't know if there is any plan of using these again, but probably they won't.

If there is no need of keeping Extract, IsEnumValid and cmd_helper.h, it is also possible to remove EnumPropsT.

If developers think so, just say it and I will remove EnumPropsT related code in another commit to this same PR.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc michicc merged commit d9a37c9 into OpenTTD:master Feb 2, 2022
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants