Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of a few actions #1

Merged
merged 21 commits into from Jan 12, 2020
Merged

Conversation

@TrueBrain
Copy link
Member

TrueBrain commented Jan 11, 2020

  • Missing READMEs for a few actions
  • README.md in root should point to the actions, and what they do

Otherwise this is tested and as far as I can tell in working order.

TrueBrain added 16 commits Jan 11, 2020
Now always a - over _ or camelCase.
Although this is twice as big as the minimized version, the
'git diff' (and with that the repository space) is significant
smaller, expecially over time. It also makes reviews a bit less
annoying, as otherwise there is this huge blob of nobody-knows
in between there.
In other words, things were dry-runs when they shouldn't, and the
other way around.
This is a new approach, which is still a bit thin. But this is the
best we could come up with for now.
This means that the format parameter did the wrong lookup.
Where 'cut' is 1-indexed, 'split()' is 0-indexed. So off-by-one error.
@glx22
Copy link

glx22 commented Jan 11, 2020

Can't getOutputFromExec() be in some kind of common library like they do for https://github.com/actions/cache/blob/master/src/save.ts and https://github.com/actions/cache/blob/master/src/restore.ts ?

@TrueBrain
Copy link
Member Author

TrueBrain commented Jan 11, 2020

src is the rootDir, and you cannot include files outside of it. They have to be packages in that case. And there is where my knowledge of TypeScript really ends. So I couldn't get it to work, but I would like it to be deduplicated.

Currently my goal is to first get it to work; after that I hope others join in to make it better :D

TrueBrain added 3 commits Jan 11, 2020
It not only contains the absolute path of the machine that builds,
it is also never used. And while doing 'ncc', it becomes part of
the 'dist' files, creating diffs that are pointless. Hopefully
this resolves that issue.
@glx22
glx22 approved these changes Jan 12, 2020
Copy link

glx22 left a comment

The current stuff is a good start, it can be improved later.

@TrueBrain TrueBrain merged commit 0e06c92 into OpenTTD:master Jan 12, 2020
@TrueBrain TrueBrain deleted the TrueBrain:first_version branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.