Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase upload-token expiration time #37

Closed
frosch123 opened this issue Apr 23, 2020 · 1 comment
Closed

Increase upload-token expiration time #37

frosch123 opened this issue Apr 23, 2020 · 1 comment
Labels

Comments

@frosch123
Copy link
Member

@frosch123 frosch123 commented Apr 23, 2020

Some content is approaching a size of 1 GB.
With some connections a upload timeout of 15 minutes is rather harsh.

It's also likely that people would start their GB upload, and go for a walk.

So I suggest to make upload-tokens expire together with the session, and not on their own.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Apr 23, 2020

I think there are two fixes to be made:

Also invalidate uploads when a session expires.
Increase the time an upload expires.

TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
With this, it now always times out after the session times out.
TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
With this, it now always times out after the session times out.
TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
With this, it now always times out after the session times out.
@TrueBrain TrueBrain closed this in da41862 Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.