Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix: change the login flow to an OAuth2 PKCE flow #15
Conversation
This avoids other websites being able to steal API tokens and modify any content on the API, without the user knowing.
If people want to register their application, they can make a pull-request. This follows OAuth2 design, although we don't have a dynamic portal to register your app, but it needs to be done via a pull-request.
|
LGTM, but the bots are not happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
TrueBrain commentedApr 19, 2020
This avoids other websites being able to steal API tokens and
modify any content on the API, without the user knowing.