Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing lots of issues #40

Merged
merged 11 commits into from Apr 25, 2020
Merged

Fixing lots of issues #40

merged 11 commits into from Apr 25, 2020

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Apr 25, 2020

One commit to rule them all, or something.

They are all small commits, but I can split them in different PRs if that is easier to review.

TrueBrain added 4 commits Apr 25, 2020
This causes the same package to be noted twice in the commit
message, and wastes disk I/O.
…ommit

The old method made no sense; it gave unreadable commit messages,
an endless stream of the same messages. This way it is much more
clear what has been going on.
@TrueBrain TrueBrain force-pushed the TrueBrain:fix_commits branch from 0fdcba3 to 80a385c Apr 25, 2020
TrueBrain added 7 commits Apr 25, 2020
Otherwise the next commit that uses HEAD can fail on empty
repositories. Git has a lot of trouble with empty repositories
in general, so lets just make sure that is never the case.
This happens if people commit something, and revert it after.
With this, it now always times out after the session times out.
@TrueBrain TrueBrain force-pushed the TrueBrain:fix_commits branch from 80a385c to d5824ec Apr 25, 2020
Copy link
Member

@frosch123 frosch123 left a comment

The two commits for #39 could be squashed.
Otherwise LGTM :)

@TrueBrain TrueBrain merged commit 04614ed into OpenTTD:master Apr 25, 2020
5 checks passed
5 checks passed
Docker build
Details
Flake8
Details
Black
Details
Regression
Details
LGTM analysis: Python No new or fixed alerts
Details
@TrueBrain TrueBrain deleted the TrueBrain:fix_commits branch Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.