Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #65: ignore errors in tarballs/zipfiles #68
There currently isn't really a way to talk back to the client that
The behaviour is now: if you upload an invalid tarball/zipfile,
How the current system is setup, there are no persistent errors. So when you validate, it checks everything again to see if it works out okay now. This is how invalid content etc is detected.
Tarballs and zipfiles are different, in that they are extracted on upload. There isn't any method of communicating any error here to the end-user.
Basically, this PR resolves the reporting to Sentry about mistakes, but doesn't fix anything towards the end-user. I am also not sure how that would work / look like.
This is a bit of a hack in comparison with the normal validation method, but these errors happen on upload, where the other errors happen on validation. Sadly, the tusd implementation is a bit wonky, and we cannot really communicate back with the client when we found such error during upload (as strictly seen the upload succeeded fine; the content is broken). So we cannot report the error on upload, and as such are forced to do it after upload.