Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connecting to developer-endpoint of bananas api #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

@erenes
Copy link

@erenes erenes commented Apr 25, 2021

Based on #21 and also OpenTTD/bananas-api#88

  • OpenTTD/bananas-api#88 introduced the same redirect flow for developer login as we have for github login.
  • #21 changed the login flow on the clientside to be handled in the actual commands instead of on startup. @TrueBrain did mention on IRC he is interested in authentication using decorators instead, but in my opinion that is not a priority for a one-liner.

In this PR I allow the user to set the oauth audience (previously hardcoded) to 'developer', and replace a hard-coded client id with the already configurable one. Finally, if the redirect url is a relative url (starting with /), the api-url is prepended.

Together with the changes on the bananas-api server side, this allows a user to use developer authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant