Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the elements in the page header #16

Closed
wants to merge 2 commits into from

Conversation

@auge8472
Copy link
Contributor

@auge8472 auge8472 commented Apr 23, 2020

Add general rules for all direct childs of the page header (body > header), font size rule for h1 and bold font weight for the optional p.

Additionally I added a commit go provide a bigger left and right padding for the direct childs of body on viewport widths of 40em or larger.

@auge8472
Copy link
Contributor Author

@auge8472 auge8472 commented Apr 23, 2020

Hi Auge, I don't want you to miss this :)

I read it before starting this request. The question for me is now: Do you plan to restore the old status?

@andythenorth
Copy link

@andythenorth andythenorth commented Apr 24, 2020

My intent is to get the old theme applied to new frontend as soon as possible, using https://github.com/andythenorth/bananas-frontend-web

After that - unknown. I want to work on newgrfs with my time, not bananas :) I don't know what other people want to see happen.

@auge8472
Copy link
Contributor Author

@auge8472 auge8472 commented Apr 27, 2020

In the light of the latest changes I close the PR.

@auge8472 auge8472 closed this Apr 27, 2020
@auge8472 auge8472 deleted the auge8472:elem-header branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants