Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: first version of the bananas_server rewritten in Python #1

Merged
merged 4 commits into from Apr 20, 2020

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Feb 27, 2020

It serves the TCP and HTTP connections from the OpenTTD client,
and requires the BaNaNaS repository to be checked out.

This repository in combination with bananas-api allows you to
run your own BaNaNaS from scratch.

@TrueBrain TrueBrain force-pushed the first_version branch 4 times, most recently from 79a4df5 to 28e8f6f Mar 15, 2020
@TrueBrain TrueBrain force-pushed the first_version branch 4 times, most recently from d2394c1 to 7050fc5 Mar 28, 2020
Copy link
Member

@LordAro LordAro left a comment

Some thoughts that occurred to me as i scrolled through the "diff", nothing too in depth

README.md Show resolved Hide resolved
content_server/index/local.py Outdated Show resolved Hide resolved
content_server/openttd/protocol/enums.py Outdated Show resolved Hide resolved
content_server/openttd/tcp_content.py Outdated Show resolved Hide resolved
content_server/openttd/tcp_content.py Outdated Show resolved Hide resolved
content_server/storage/local.py Outdated Show resolved Hide resolved
content_server/storage/local.py Outdated Show resolved Hide resolved
content_server/storage/local.py Outdated Show resolved Hide resolved
content_server/web_routes.py Outdated Show resolved Hide resolved
@TrueBrain TrueBrain force-pushed the first_version branch 2 times, most recently from c11edba to b33bdc2 Apr 5, 2020
@TrueBrain TrueBrain force-pushed the first_version branch 2 times, most recently from eb74c5c to 24dd659 Apr 11, 2020
@TrueBrain TrueBrain marked this pull request as ready for review Apr 11, 2020
@TrueBrain TrueBrain force-pushed the first_version branch 2 times, most recently from c365821 to bcb2419 Apr 11, 2020
@TrueBrain TrueBrain changed the title Add: first version of the content_server rewritten in Python Add: first version of the bananas_server rewritten in Python Apr 11, 2020
@TrueBrain TrueBrain force-pushed the first_version branch 2 times, most recently from a77d384 to 4d68532 Apr 12, 2020
It serves the TCP and HTTP connections from the OpenTTD client.

This repository in combination with bananas-api allows you to
run your own BaNaNaS from scratch.
bananas_server/application/bananas_server.py Outdated Show resolved Hide resolved
bananas_server/application/bananas_server.py Show resolved Hide resolved
bananas_server/application/bananas_server.py Outdated Show resolved Hide resolved
bananas_server/application/bananas_server.py Show resolved Hide resolved
(letter >= "a" and letter <= "z")
or (letter >= "A" and letter <= "Z")
or (letter >= "0" and letter <= "9")
or letter == "."
Copy link
Member

@frosch123 frosch123 Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not allow "." in first position?

Copy link
Member Author

@TrueBrain TrueBrain Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not disagreeing, but there are more things I would like to fix. For now I did what musa did:
https://github.com/OpenTTD/musa/blob/68bf7d1f1983f028ec2b2a775fe421618d6a4c0c/misc.py#L91
(only written in better Python). I guess we can clean up some more .. like no starting with _ or ending with it :D

frosch123
frosch123 previously approved these changes Apr 20, 2020
@TrueBrain TrueBrain merged commit f44afb0 into OpenTTD:master Apr 20, 2020
3 checks passed
@TrueBrain TrueBrain deleted the first_version branch Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants