Fix CodeQL warning and a sentry crash report #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
previously approved these changes
Oct 3, 2020
Now it triggered an exception, crashing the server. This happens rarely, and only if a client connection is very slow. As this is already the fallback of the normal download flow, we are left with no alternatives: the client cannot download the file via a more reliable HTTP connection, and is downloading over our TCP connection in such a slow speed, the S3 backend gives up on it. The only reasonable thing to do, is to drop the connection to the client on our end too.
For development this is useful, meaning you don't need a full library in order to debug the server.
LordAro
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: