Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeQL warning and a sentry crash report #33

Merged
merged 3 commits into from Oct 3, 2020

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Oct 3, 2020

No description provided.

LordAro
LordAro previously approved these changes Oct 3, 2020
TrueBrain added 3 commits Oct 3, 2020
Now it triggered an exception, crashing the server. This happens
rarely, and only if a client connection is very slow. As this is
already the fallback of the normal download flow, we are left
with no alternatives: the client cannot download the file via a
more reliable HTTP connection, and is downloading over our TCP
connection in such a slow speed, the S3 backend gives up on it.
The only reasonable thing to do, is to drop the connection to
the client on our end too.
For development this is useful, meaning you don't need a full
library in order to debug the server.
LordAro
LordAro approved these changes Oct 3, 2020
@TrueBrain TrueBrain merged commit 243ac7d into OpenTTD:master Oct 3, 2020
6 checks passed
@TrueBrain TrueBrain deleted the codeql_fixes branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants