Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't report SocketClosed when sending #34

Merged
merged 1 commit into from Oct 3, 2020

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Oct 3, 2020

SocketClosed happens when the other side closed the connection,
and is pretty common in production. The caller knows how to handle
this signal just fine, so pass it through.

SocketClosed happens when the other side closed the connection,
and is pretty common in production. The caller knows how to handle
this signal just fine, so pass it through.
@LordAro
LordAro approved these changes Oct 3, 2020
@TrueBrain TrueBrain merged commit 51f3815 into OpenTTD:master Oct 3, 2020
6 checks passed
6 checks passed
Commit checker
Details
Security and Quality
Details
Docker build
Details
Flake8
Details
Black
Details
CodeQL No new alerts
Details
@TrueBrain TrueBrain deleted the TrueBrain:fix_socket_closed branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants