Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: support more than one CDN url #37

Merged
merged 1 commit into from Nov 22, 2020
Merged

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Nov 14, 2020

This is useful to distribute load/cost over multiple servers.

This is useful to distribute load/cost over multiple servers.
@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Nov 21, 2020

@LordAro @frosch123 : could either of you review this? Cheers!

bananas_server/web_routes.py Show resolved Hide resolved
async def check_cdn_health():
await asyncio.sleep(1)

log.info("Healthchecks for CDN servers %r enabled", CDN_URL)

This comment has been minimized.

This comment has been minimized.

@TrueBrain

TrueBrain Nov 22, 2020
Author Member

yes, %r. CDN_URL is a list or None, so using __repr__ gives the best readable result, without doing complex things. Not sure what your question is here honestly :)

This comment has been minimized.

@LordAro

LordAro Nov 22, 2020
Member

Just didn't recognise it

@TrueBrain TrueBrain merged commit d12b5b3 into OpenTTD:master Nov 22, 2020
6 checks passed
6 checks passed
Commit checker
Details
Security and Quality
Details
Docker build
Details
Flake8
Details
Black
Details
CodeQL No new alerts
Details
@TrueBrain TrueBrain deleted the TrueBrain:vps_support branch Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.